r112581 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112580‎ | r112581 | r112582 >
Date:08:37, 28 February 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
add RTL styling rules

this ensures the mobile site renders correctly for languages
such as hebrew
Note: we may want to separate this into a separate stylesheet as
these rules are unused for LTR languages
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -15,6 +15,11 @@
1616 display: none;
1717 }
1818
 19+html[dir="rtl"] .clearlink {
 20+ left: 0.25em;
 21+ right: auto;
 22+}
 23+
1924 #zero-rated-banner {
2025 position: relative;
2126 height: 20px;
@@ -100,7 +105,6 @@
101106 margin: 0;
102107 line-height: 1.8em;
103108 padding: 0.01em 0.25em;
104 - text-align: left;
105109 postion: relative;
106110 border-bottom: solid 1px #999999;
107111 }
@@ -173,6 +177,10 @@
174178 left: 53px;
175179 }
176180
 181+html[dir="rtl"] #results {
 182+ left: 41px;
 183+}
 184+
177185 #search {
178186 width: 90%;
179187 -webkit-appearance: none;
@@ -561,15 +569,23 @@
562570 -webkit-border-radius: 2px;
563571 -moz-border-radius: 2px;
564572 }
565 -
 573+
 574+html[dir="rtl"] #searchbox {
 575+ padding: 5px 44px 5px 32px
 576+}
 577+
566578 #searchbox #form {
567579 padding-right: 34px;
568580 width: 100%;
569581 }
570582
 583+html[dir="rtl"] #logo,
571584 #goButton {
572585 position: absolute;
573586 right: 2px;
 587+}
 588+
 589+#goButton {
574590 top: 2px;
575591 border: 0;
576592 background: url(images/s.gif) no-repeat top left;
@@ -578,6 +594,11 @@
579595 width: 27px;
580596 }
581597
 598+html[dir="rtl"] #goButton {
 599+ right: auto;
 600+ left: 2px;
 601+}
 602+
582603 #searchbox a,
583604 #searchbox img {
584605 border: 0px;
@@ -607,10 +628,19 @@
608629 float: left;
609630 }
610631
 632+html[dir="rtl"] #nav {
 633+ float: right;
 634+}
 635+
611636 #languageselection {
612637 margin-right: 35px;
613638 }
614639
 640+html[dir="rtl"] #languageselection {
 641+ margin-right: 0;
 642+ margin-left: 35px;
 643+}
 644+
615645 #nav form,
616646 #nav button {
617647 display: inline-block;
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -34,6 +34,11 @@
3535 display: none;
3636 }
3737
 38+html[dir="rtl"] .clearlink {
 39+ left: 0.25em;
 40+ right: auto;
 41+}
 42+
3843 #zero-rated-banner {
3944 position: relative;
4045 height: 20px;
@@ -120,7 +125,6 @@
121126 margin: 0;
122127 line-height: 2.6em;
123128 padding: 0.01em 0.25em;
124 - text-align: left;
125129 postion: relative;
126130 border-bottom: solid 1px #999999;
127131 }
@@ -566,9 +570,13 @@
567571 width: 100%;
568572 }
569573
 574+html[dir="rtl"] #logo,
570575 #goButton {
571576 position: absolute;
572577 right: 2px;
 578+}
 579+
 580+#goButton {
573581 top: 2px;
574582 border: 0;
575583 background: url(images/s.gif) no-repeat top left;
@@ -577,6 +585,11 @@
578586 width: 27px;
579587 }
580588
 589+html[dir="rtl"] #goButton {
 590+ right: auto;
 591+ left: 2px;
 592+}
 593+
581594 #searchbox a,
582595 #searchbox img {
583596 border: 0px;
@@ -607,10 +620,19 @@
608621 float: left;
609622 }
610623
 624+html[dir="rtl"] #nav {
 625+ float: right;
 626+}
 627+
611628 #languageselection {
612629 margin-right: 35px;
613630 }
614631
 632+html[dir="rtl"] #languageselection {
 633+ margin-right: 0;
 634+ margin-left: 35px;
 635+}
 636+
615637 #nav form,
616638 #nav button {
617639 display: inline-block;
@@ -682,6 +704,11 @@
683705 font-size: 1.2em;
684706 }
685707
 708+html[dir="rtl"] .full-screen-search #sq {
 709+ padding-left: 0;
 710+ padding-right: 44px;
 711+}
 712+
686713 .full-screen-search #sq {
687714 position: relative;
688715 padding-left: 44px;
@@ -720,7 +747,6 @@
721748 .full-screen-search .suggestions-results {
722749 line-height: 2.6em;
723750 padding: 0;
724 - text-align: left;
725751 position: relative;
726752 border-bottom: solid 1px #999;
727753 font-size: 1.4em;
@@ -756,6 +782,11 @@
757783 overflow: hidden;
758784 }
759785
 786+html[dir="rtl"] #remove-results {
 787+ right: 0px;
 788+ left: auto;
 789+}
 790+
760791 .full-screen-search #results {
761792 display: block !important;
762793 }

Status & tagging log