r112485 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112484‎ | r112485 | r112486 >
Date:14:41, 27 February 2012
Author:siebrand
Status:ok
Tags:
Comment:
Add special page aliases.
Add some message documentation.
Add fixme for large init file.
Modified paths:
  • /trunk/extensions/ArticleComments/ArticleComments.alias.php (added) (history)
  • /trunk/extensions/ArticleComments/ArticleComments.i18n.php (modified) (history)
  • /trunk/extensions/ArticleComments/ArticleComments.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleComments/ArticleComments.php
@@ -22,6 +22,8 @@
2323 * <comments />
2424 * Note: Typically this would be placed at the end of the article text.
2525 * Version Notes:
 26+ * version 0.6.1:
 27+ * Added internationalisation for special page names.
2628 * version 0.6:
2729 * Added comments inside <comment> tags instead of article-comments-new-comment message.
2830 * version 0.5.1:
@@ -85,13 +87,15 @@
8688 'path' => __FILE__,
8789 'name' => 'ArticleComments',
8890 'author' => array( 'Jim R. Wilson', 'Platonides' ),
89 - 'version' => '0.6',
 91+ 'version' => '0.6.1',
9092 'url' => 'https://www.mediawiki.org/wiki/Extension:ArticleComments',
9193 'descriptionmsg' => 'article-comments-desc',
9294 );
9395
9496 # Add extension internationalization messages
95 -$wgExtensionMessagesFiles['ArticleComments'] = dirname( __FILE__ ) . '/ArticleComments.i18n.php';
 97+$dir = dirname( __FILE__ ) . '/';
 98+$wgExtensionMessagesFiles['ArticleComments'] = $dir . 'ArticleComments.i18n.php';
 99+$wgExtensionMessagesFiles['ArticleCommentsAlias'] = $dir . 'ArticleComments.alias.php';
96100
97101 # Attach hooks
98102 $wgHooks['ParserFirstCallInit'][] = 'wfArticleCommentsParserSetup';
@@ -118,6 +122,8 @@
119123 # Sets up special page to handle comment submission
120124 $wgSpecialPages['ProcessComment'] = 'SpecialProcessComment';
121125
 126+// @todo FIXME: Put hooks and class in separate files and use autoloader.
 127+
122128 # Sets up the ArticleComments Parser hook for <comments />
123129 function wfArticleCommentsParserSetup( &$parser ) {
124130 $parser->setHook( 'comments', 'wfArticleCommentsParserHook' );
Index: trunk/extensions/ArticleComments/ArticleComments.alias.php
@@ -0,0 +1,14 @@
 2+<?php
 3+/**
 4+ * Aliases for extension ArticleComments
 5+ *
 6+ * @file
 7+ * @ingroup Extensions
 8+ */
 9+
 10+$specialPageAliases = array();
 11+
 12+/** English (English) */
 13+$specialPageAliases['en'] = array(
 14+ 'ProcessComment' => array( 'ProcessComment' ),
 15+);
Property changes on: trunk/extensions/ArticleComments/ArticleComments.alias.php
___________________________________________________________________
Added: svn:eol-style
116 + native
Added: svn:keywords
217 + Id
Index: trunk/extensions/ArticleComments/ArticleComments.i18n.php
@@ -67,6 +67,7 @@
6868 'article-comments-commenter-said' => '$1 is a value filled into a form field by a commenter. It is not necessarily related to any wiki user name.',
6969 'article-comments-summary' => '$1 is a value filled into a form field by a commenter. It is not necessarily related to any wiki user name.',
7070 'article-comments-comment-bad-mode' => '{{doc-important|Do not translate the words "plain", "normal" and "wiki".}}',
 71+ 'processcomment' => 'Special page title and link description on Special:SpecialPages.',
7172 );
7273
7374 /** Afrikaans (Afrikaans)

Sign-offs

UserFlagDate
Nikerabbitinspected06:49, 28 February 2012

Status & tagging log