r112483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112482‎ | r112483 | r112484 >
Date:13:18, 27 February 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
remove third redundant argument to bind function

this is not being used for anything
Modified paths:
  • /trunk/extensions/MobileFrontend/javascripts/application.js (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/beta_application.js (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/opensearch.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/opensearch.js
@@ -53,7 +53,7 @@
5454 } else {
5555 timer = setTimeout( function () { searchApi( term ); }, typingDelay );
5656 }
57 - }, false );
 57+ } );
5858 };
5959
6060 function searchApi( term ) {
@@ -167,9 +167,9 @@
168168 function onFocusHandler() {
169169 search.select();
170170 }
171 - u( clearSearch ).bind( 'mousedown', clearSearchBox, true );
172 - u( search ).bind( 'keyup', handleClearSearchLink, false );
173 - u( search ).bind( 'click', onFocusHandler, true );
 171+ u( clearSearch ).bind( 'mousedown', clearSearchBox );
 172+ u( search ).bind( 'keyup', handleClearSearchLink );
 173+ u( search ).bind( 'click', onFocusHandler );
174174 }
175175
176176 function init() {
Index: trunk/extensions/MobileFrontend/javascripts/beta_application.js
@@ -30,7 +30,7 @@
3131 heading = sectionHeadings[i];
3232 heading.insertBefore( createButton( true ), heading.firstChild );
3333 heading.insertBefore( createButton( false ), heading.firstChild );
34 - utilities( heading ).bind( 'click', openSectionHandler, false );
 34+ utilities( heading ).bind( 'click', openSectionHandler );
3535 }
3636 results = document.getElementById( 'results' );
3737 languageSelection = document.getElementById( 'languageselection' );
Index: trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js
@@ -31,7 +31,7 @@
3232 viewportmeta.content = 'width=device-width, minimum-scale=1.0, maximum-scale=1.0, initial-scale=1.0';
3333 u( document.body ).bind( 'gesturestart', function () {
3434 viewportmeta.content = 'width=device-width, initial-scale=1.0';
35 - }, false );
 35+ } );
3636 }
3737 }
3838 }
@@ -146,7 +146,7 @@
147147 term = encodeURIComponent( term );
148148 timer = setTimeout( function () { searchApi( term ); }, typingDelay );
149149 }
150 - }, false );
 150+ } );
151151 };
152152
153153 function searchApi( term ) {
@@ -276,10 +276,10 @@
277277 function onFocusHandler() {
278278 search.select();
279279 }
280 - u( clearSearch ).bind( 'mousedown', clearSearchBox, true );
281 - u( search ).bind( 'keyup', handleClearSearchLink, false );
282 - u( search ).bind( 'keydown', handleDefaultText, false );
283 - u( search ).bind( 'click', onFocusHandler, true );
 280+ u( clearSearch ).bind( 'mousedown', clearSearchBox );
 281+ u( search ).bind( 'keyup', handleClearSearchLink );
 282+ u( search ).bind( 'keydown', handleDefaultText );
 283+ u( search ).bind( 'click', onFocusHandler );
284284 }
285285
286286 function init() {
Index: trunk/extensions/MobileFrontend/javascripts/application.js
@@ -26,7 +26,7 @@
2727 heading = sectionHeadings[i];
2828 heading.insertBefore( createButton( true ), heading.firstChild );
2929 heading.insertBefore( createButton( false ), heading.firstChild );
30 - utilities( heading ).bind( 'click', openSectionHandler, false );
 30+ utilities( heading ).bind( 'click', openSectionHandler );
3131 }
3232 results = document.getElementById( 'results' );
3333 languageSelection = document.getElementById( 'languageselection' );

Status & tagging log