r112438 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112437‎ | r112438 | r112439 >
Date:14:21, 26 February 2012
Author:nikerabbit
Status:deferred
Tags:
Comment:
Removed code that does nothing and added todo
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/api/ApiAsk.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/api/ApiAskArgs.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/api/ApiSMWInfo.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/api/ApiSMWQuery.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/api/ApiSMWInfo.php
@@ -86,11 +86,6 @@
8787 'API module get info about this SMW install.'
8888 );
8989 }
90 -
91 - public function getPossibleErrors() {
92 - return array_merge( parent::getPossibleErrors(), array(
93 - ) );
94 - }
9590
9691 protected function getExamples() {
9792 return array(
Index: trunk/extensions/SemanticMediaWiki/includes/api/ApiAskArgs.php
@@ -80,11 +80,6 @@
8181 This API module is in alpha stage, and likely to see changes in upcomming versions of SMW.'
8282 );
8383 }
84 -
85 - public function getPossibleErrors() {
86 - return array_merge( parent::getPossibleErrors(), array(
87 - ) );
88 - }
8984
9085 protected function getExamples() {
9186 return array(
Index: trunk/extensions/SemanticMediaWiki/includes/api/ApiSMWQuery.php
@@ -75,11 +75,7 @@
7676 }
7777 }
7878
79 - public function getPossibleErrors() {
80 - return array_merge( parent::getPossibleErrors(), array(
81 - ) );
82 - }
83 -
 79+ /// TODO: when < 1.17 are no longer supported, use ApiBase::PARAM_REQUIRED
8480 protected function requireParameters( array $params, array $required ) {
8581 foreach ( $required as $param ) {
8682 if ( !isset( $params[$param] ) ) {
Index: trunk/extensions/SemanticMediaWiki/includes/api/ApiAsk.php
@@ -52,11 +52,6 @@
5353 This API module is in alpha stage, and likely to see changes in upcomming versions of SMW.'
5454 );
5555 }
56 -
57 - public function getPossibleErrors() {
58 - return array_merge( parent::getPossibleErrors(), array(
59 - ) );
60 - }
6156
6257 protected function getExamples() {
6358 return array(