r112432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112431‎ | r112432 | r112433 >
Date:13:07, 26 February 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Removing code thas been commented out almost a year, ping r88308
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php
@@ -110,18 +110,6 @@
111111 }
112112
113113 /**
114 - * Determine the datatype of the values that are described by this object.
115 - * Most descriptins can only describe wiki pages, so this is the default,
116 - * but some descriptions may refer to other datatypes, and overwrite this
117 - * function accordingly.
118 - *
119 - * @return string
120 - */
121 -// public function getTypeID() {
122 -// return '_wpg';
123 -// }
124 -
125 - /**
126114 * Recursively restrict query to a maximal size and depth as given.
127115 * Returns a possibly changed description that should be used as a replacement.
128116 * Reduce values of parameters to account for the returned descriptions size.
@@ -177,16 +165,6 @@
178166 return $this;
179167 }
180168
181 - /**
182 - * Return an empty type id since we cannot know the datatype of values that
183 - * are described by this description. This type should not be relevant in
184 - * any place, since description types are currently only necessary for
185 - * processing an SMWSomeProperty object where the property does not specify
186 - * the type.
187 - */
188 -// public function getTypeID() {
189 -// return '';
190 -// }
191169 }
192170
193171 /**
@@ -462,10 +440,6 @@
463441 return 1;
464442 }
465443
466 -// public function getTypeID() {
467 -// return $this->m_dataItem->getTypeID();
468 -// }
469 -
470444 }
471445
472446
@@ -548,14 +522,6 @@
549523 return $depth;
550524 }
551525
552 -// public function getTypeID() {
553 -// if ( count( $this->m_descriptions ) > 0 ) { // all subdescriptions should have the same type!
554 -// return reset( $this->m_descriptions )->getTypeID();
555 -// } else {
556 -// return ''; // unknown
557 -// }
558 -// }
559 -
560526 public function getQueryFeatures() {
561527 $result = SMW_CONJUNCTION_QUERY;
562528
@@ -718,14 +684,6 @@
719685 return $depth;
720686 }
721687
722 -// public function getTypeID() {
723 -// if ( count( $this->m_descriptions ) > 0 ) { // all subdescriptions should have the same type!
724 -// return reset( $this->m_descriptions )->getTypeID();
725 -// } else {
726 -// return ''; // unknown
727 -// }
728 -// }
729 -
730688 public function getQueryFeatures() {
731689 $result = SMW_DISJUNCTION_QUERY;
732690

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88308Removed type ids from data items. The type of the property that a piece of da...mkroetzsch14:53, 17 May 2011

Status & tagging log