r112403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112402‎ | r112403 | r112404 >
Date:17:24, 25 February 2012
Author:siebrand
Status:ok
Tags:
Comment:
Write some output to error log in case a message group has 0 messages. Makes mistakes like that from r111791 a bit easier to identify.
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialLanguageStats.php (modified) (history)
  • /trunk/extensions/Translate/specials/SpecialMessageGroupStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialMessageGroupStats.php
@@ -167,6 +167,10 @@
168168 $this->incomplete = true;
169169 $extra = array();
170170 } else {
 171+ if( $total === 0 ) {
 172+ error_log( $groupId . ' has 0 messages.' );
 173+ }
 174+
171175 if ( $this->noComplete && $fuzzy === 0 && $translated === $total ) {
172176 return '';
173177 }
Index: trunk/extensions/Translate/specials/SpecialLanguageStats.php
@@ -376,6 +376,10 @@
377377 $this->incomplete = true;
378378 $extra = array();
379379 } else {
 380+ if( $total === 0 ) {
 381+ error_log( $groupId . ' has 0 messages.' );
 382+ }
 383+
380384 if ( $this->noComplete && $fuzzy === 0 && $translated === $total ) {
381385 return '';
382386 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111791r111786: extension movedraymond21:23, 17 February 2012

Status & tagging log