r112335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112334‎ | r112335 | r112336 >
Date:18:16, 24 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Avoid some path hard-coding in onWfShellMaintenanceCmd(). If we are running MW in /usr, then /home is likely not mounted (in which case we can't use the /home MWScript file). Just use the corresponding MWScript file.
Modified paths:
  • /trunk/tools/mwmultiversion/multiversion/MWMultiVersion.php (modified) (history)

Diff [purge]

Index: trunk/tools/mwmultiversion/multiversion/MWMultiVersion.php
@@ -227,7 +227,7 @@
228228 global $IP;
229229 if ( strpos( $script, "{$IP}/" ) === 0 ) {
230230 $script = substr( $script, strlen( "{$IP}/" ) );
231 - $options['wrapper'] = '/home/wikipedia/common/multiversion/MWScript.php';
 231+ $options['wrapper'] = dirname( __FILE__ ) . '/MWScript.php';
232232 }
233233 return true;
234234 }

Status & tagging log