r112320 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112319‎ | r112320 | r112321 >
Date:14:23, 24 February 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Fix help link html getting added twice (was not visible in the page)
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialSupportedLanguages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialSupportedLanguages.php
@@ -36,17 +36,20 @@
3737 $this->purge = $wgRequest->getVal( 'action' ) === 'purge';
3838
3939 $this->setHeaders();
40 - TranslateUtils::addSpecialHelpLink( $wgOut, 'Help:Extension:Translate/Statistics_and_reporting#List_of_languages_and_translators' );
4140 $wgOut->addModules( 'ext.translate.special.supportedlanguages' );
4241
 42+ // Do not add html content to OutputPage before this block of code!
4343 $cache = wfGetCache( CACHE_ANYTHING );
4444 $cachekey = wfMemcKey( 'translate-supportedlanguages', $wgLang->getCode() );
4545 $data = $cache->get( $cachekey );
4646 if ( !$this->purge && is_string( $data ) ) {
 47+ TranslateUtils::addSpecialHelpLink( $wgOut, 'Help:Extension:Translate/Statistics_and_reporting#List_of_languages_and_translators' );
4748 $wgOut->addHtml( $data );
4849 return;
4950 }
5051
 52+ TranslateUtils::addSpecialHelpLink( $wgOut, 'Help:Extension:Translate/Statistics_and_reporting#List_of_languages_and_translators' );
 53+
5154 $this->outputHeader();
5255 $wgOut->addWikiMsg( 'supportedlanguages-colorlegend', $this->getColorLegend() );
5356 $wgOut->addWikiMsg( 'supportedlanguages-localsummary' );

Status & tagging log