r112302 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112301‎ | r112302 | r112303 >
Date:05:20, 24 February 2012
Author:tstarling
Status:ok
Tags:
Comment:
Partial revert of r111989: the FundraiserPortal change appears to have been both broken an unnecessary.
Modified paths:
  • /trunk/extensions/FundraiserPortal/Templates/donateScripts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/FundraiserPortal/Templates/donateScripts.js
@@ -38,11 +38,9 @@
3939 }
4040 }
4141
42 -jQuery( document ).ready( function() {
43 - var wgDonateButton = getDonateButton();
 42+var wgDonateButton = getDonateButton();
4443
45 - if ( ! wgDonateButton ) {
46 - var wgDonateButton = pickDonateButton();
47 - setDonateButton( wgDonateButton );
48 - }
49 -} );
 44+if ( ! wgDonateButton ) {
 45+ var wgDonateButton = pickDonateButton();
 46+ setDonateButton( wgDonateButton );
 47+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111989* (bug 34538) Fixed compatibility with $wgResourceLoaderExperimentalAsyncLoad...tstarling04:03, 21 February 2012

Status & tagging log