r112298 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112297‎ | r112298 | r112299 >
Date:04:29, 24 February 2012
Author:tstarling
Status:ok
Tags:
Comment:
ContribsPager can't accept multiple namespaces, passing an array causes a warning in DatabaseMysql::strencode(). Not sure if/how this worked in 1.18 but it's broken in 1.19wmf1. Tested.
Modified paths:
  • /trunk/phase3/includes/api/ApiFeedContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFeedContributions.php
——@@ -150,8 +150,7 @@
151151 ApiBase::PARAM_REQUIRED => true,
152152 ),
153153 'namespace' => array(
154 - ApiBase::PARAM_TYPE => 'namespace',
155 - ApiBase::PARAM_ISMULTI => true
 154+ ApiBase::PARAM_TYPE => 'namespace'
156155 ),
157156 'year' => array(
158157 ApiBase::PARAM_TYPE => 'integer'

Follow-up revisions

RevisionCommit summaryAuthorDate
r112299MFT r112298: mysql_real_escape_string() warningtstarling04:31, 24 February 2012

Status & tagging log