r112159 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112158‎ | r112159 | r112160 >
Date:22:45, 22 February 2012
Author:krinkle
Status:ok
Tags:
Comment:
[MarkAsHelpful] js/css clean up
* Whitespace
* newline at end of file
Modified paths:
  • /trunk/extensions/MarkAsHelpful/modules/ext.markAsHelpful/ext.markAsHelpful.css (modified) (history)
  • /trunk/extensions/MarkAsHelpful/modules/ext.markAsHelpful/ext.markAsHelpful.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MarkAsHelpful/modules/ext.markAsHelpful/ext.markAsHelpful.css
@@ -1,20 +1,20 @@
2 -.mw-mah-wrapper a{
3 - cursor:pointer;
 2+.mw-mah-wrapper a {
 3+ cursor: pointer;
44 }
55
66 .mw-mah-wrapper .mah-helpful-state {
77 /* @embed */
8 - background: transparent url(images/mah-helpful-dull.png) left center no-repeat;
 8+ background: transparent url(images/mah-helpful-dull.png) no-repeat left center;
99 padding-left: 18px;
1010 }
1111
1212 .mw-mah-wrapper .mah-helpful-state:hover {
1313 /* @embed */
14 - background: transparent url(images/mah-helpful-hover.png) left center no-repeat;
 14+ background: transparent url(images/mah-helpful-hover.png) no-repeat left center;
1515 }
1616
1717 .mw-mah-wrapper .mah-helpful-marked-state {
1818 /* @embed */
19 - background: transparent url(images/mah-helpful-marked.png) left center no-repeat;
20 - padding-left:18px;
21 -}
\ No newline at end of file
 19+ background: transparent url(images/mah-helpful-marked.png) no-repeat left center;
 20+ padding-left: 18px;
 21+}
Index: trunk/extensions/MarkAsHelpful/modules/ext.markAsHelpful/ext.markAsHelpful.js
@@ -18,14 +18,14 @@
1919 props = mah.getItemProperties( $(el) );
2020 // Create an item reference to place in the loaded items array.
2121 thisItem = props.type + props.item;
22 -
 22+
2323 // Load once per type+id because user can copy / paste element on the talk page
2424 // and load the same item many times.
25 - if( $.inArray( thisItem, mah.loadedItems ) === -1 ) {
 25+ if ( $.inArray( thisItem, mah.loadedItems ) === -1 ) {
2626 mah.loadedItems.push( thisItem );
2727 mah.loadItem( $( el ) );
2828 }
29 - });
 29+ });
3030 },
3131
3232 /**
@@ -36,7 +36,7 @@
3737 var tag, props;
3838
3939 tag = $item.attr( 'class' );
40 - // Item properties are stored in classname to prevent parser from stripping
 40+ // Item properties are stored in classname to prevent parser from stripping
4141 // out non html 5 objects. (eg. data-markashelpful-item)
4242 props = {
4343 // item id
@@ -85,7 +85,7 @@
8686 },
8787 dataType: 'json'
8888 });
89 -
 89+
9090 },
9191
9292 /**
@@ -112,7 +112,7 @@
113113 url: mw.util.wikiScript( 'api' ),
114114 data: request,
115115 success: function () {
116 - mah.loadItem( $item );
 116+ mah.loadItem( $item );
117117 },
118118 dataType: 'json'
119119 } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112158[MarkAsHelpful] js/css clean up...krinkle22:33, 22 February 2012

Status & tagging log