r112136 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112135‎ | r112136 | r112137 >
Date:19:12, 22 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/logging/LogFormatter.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/logging/LogFormatter.php
@@ -171,6 +171,7 @@
172172 */
173173 public function getIRCActionText() {
174174 $this->plaintext = true;
 175+ $this->irctext = true;
175176 $text = $this->getActionText();
176177
177178 $entry = $this->entry;
@@ -250,6 +251,7 @@
251252 break;
252253 }
253254 break;
 255+
254256
255257 // case 'suppress' --private log -- aaron (sign your messages so we know who to blame in a few years :-D)
256258 // default:
@@ -259,6 +261,7 @@
260262 }
261263
262264 $this->plaintext = false;
 265+ $this->irctext = false;
263266 return $text;
264267 }
265268
@@ -521,7 +524,11 @@
522525 );
523526
524527 $performer = $this->getPerformerElement();
525 - return $performer . $this->msg( 'word-separator' )->text() . $action;
 528+ if ( !$this->irctext ) {
 529+ $action = $performer . $this->msg( 'word-separator' )->text() . $action;
 530+ }
 531+
 532+ return $action;
526533 }
527534
528535 }
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
529536 Merged /trunk/phase3/includes:r112132-112133
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
530537 Merged /trunk/phase3:r112132-112133

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112132Uglier than ugly hack to fix block log any many others by not having the user...nikerabbit18:56, 22 February 2012
r112133Followup, restore the irctext variable just in vase, ping r112132nikerabbit19:01, 22 February 2012

Status & tagging log