r112120 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112119‎ | r112120 | r112121 >
Date:17:13, 22 February 2012
Author:yonishostak
Status:ok
Tags:
Comment:
AFTv5: sync commit, more visual requirements match
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -523,9 +523,18 @@
524524 text-decoration: none;
525525 }
526526 #articlefeedbackv5-activity-log {
527 - width: 300px;
 527+ width: 350px;
528528 height: 360px;
529529 }
 530+.articleFeedbackv5-activity-feedback {
 531+ padding: 10px 10px;
 532+ height: 29px;
 533+}
 534+.articleFeedbackv5-activity-feedback-permalink {
 535+ position: absolute;
 536+ top: 62px;
 537+ right: 22px;
 538+}
530539 .articleFeedbackv5-activity-pane {
531540 height: 70px;
532541 }
@@ -549,3 +558,13 @@
550559 color: red;
551560 padding: 0 5px;
552561 }
 562+.articleFeedbackv5-post-screen {
 563+ z-index: 99;
 564+ margin: 0 -10px 0 0;
 565+ position: absolute;
 566+ top: 0;
 567+ left: 0;
 568+ width: 100%;
 569+ height: 100%;
 570+ background-color: #dae2eb;
 571+}
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -457,7 +457,6 @@
458458
459459 // }}}
460460 // {{{ markHidden
461 -
462461 /**
463462 * Utility method: Marks a feedback row hidden
464463 *
@@ -472,11 +471,10 @@
473472 $( '<span class="articleFeedbackv5-feedback-hidden-marker"></span>' )
474473 .text( mw.msg( 'articlefeedbackv5-hidden' ) )
475474 .insertBefore( $row.find( '.articleFeedbackv5-comment-wrap h3' ) );
 475+ $.articleFeedbackv5special.maskPost( $row );
476476 };
477 -
478477 // }}}
479478 // {{{ unmarkHidden
480 -
481479 /**
482480 * Utility method: Unmarks as hidden a feedback row
483481 *
@@ -487,10 +485,19 @@
488486 .data( 'hidden', false );
489487 $row.find( '.articleFeedbackv5-feedback-hidden-marker' ).remove();
490488 };
491 -
492489 // }}}
 490+ // {{{ maskPost
 491+ $.articleFeedbackv5special.maskPost = function( $row ) {
 492+ var $screen = $( '<div></div>' )
 493+ .addClass( 'articleFeedbackv5-post-screen' )
 494+ .height( $row.innerHeight() )
 495+ .click( function( e ) {
 496+ $( e.target ).remove();
 497+ });
 498+ $row.prepend( $screen );
 499+ }
 500+ // }}}
493501 // {{{ markDeleted
494 -
495502 /**
496503 * Utility method: Marks a feedback row deleted
497504 *
@@ -505,6 +512,7 @@
506513 var $marker = $( '<span class="articleFeedbackv5-feedback-deleted-marker"></span>' )
507514 .text( mw.msg( 'articlefeedbackv5-deleted' ) )
508515 .insertBefore( $row.find( '.articleFeedbackv5-comment-wrap h3' ) );
 516+ $.articleFeedbackv5special.maskPost( $row );
509517 };
510518
511519 // }}}
@@ -1021,7 +1029,7 @@
10221030 },
10231031
10241032 // Cancel oversight request action
1025 - 'unrequestOversight': {
 1033+ 'unrequestoversight': {
10261034 'hasTipsy': true,
10271035 'tipsyHtml': undefined,
10281036 'click': $.articleFeedbackv5special.toggleTipsy,

Status & tagging log