r112091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112090‎ | r112091 | r112092 >
Date:08:58, 22 February 2012
Author:hashar
Status:ok
Tags:
Comment:
tests not throwing an exception are successes

Ping r106113
Modified paths:
  • /trunk/extensions/CodeReview/tests/DiffHighlighterTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/tests/DiffHighlighterTest.php
@@ -7,6 +7,7 @@
88 CodeDiffHighlighter::parseChunkDelimiter(
99 "@@ -1,3 +1,4 @@\r\n"
1010 );
 11+ $this->assertTrue( true, 'Managed to parse a chunk with \r\n' );
1112 } catch( Exception $e ) {
1213 $this->fail( "parseChunkDelimiter() could not parse a chunk finishing with '\\r\\n' This is happening on Windows" );
1314 }
@@ -17,6 +18,7 @@
1819 CodeDiffHighlighter::parseChunkDelimiter(
1920 "@@ -1,3 +1,4 @@\n"
2021 );
 22+ $this->assertTrue( true, 'Managed to parse a chunk with \n' );
2123 } catch( Exception $e ) {
2224 $this->fail( "parseChunkDelimiter() could not parse a chunk finishing with '\\n' This is happening on Unix systems" );
2325 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106113parseChunkDelimiter is now newline agnostic...hashar22:03, 13 December 2011

Status & tagging log