r112057 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112056‎ | r112057 | r112058 >
Date:22:43, 21 February 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
follow advice of r112020

merge duplicate css definitions
and adhere to coding style conventions!
Modified paths:
  • /trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js
@@ -47,7 +47,7 @@
4848 resetViewPort();
4949
5050 if ( !focused ) {
51 - MobileFrontend.utils(document.body).addClass("full-screen-search");
 51+ MobileFrontend.utils( document.body ).addClass( 'full-screen-search' );
5252 sq.className = '';
5353 results.style.width = document.body.clientWidth + pixels;
5454
@@ -84,7 +84,7 @@
8585 };
8686
8787 function removeResults() {
88 - MobileFrontend.utils(document.body).removeClass("full-screen-search");
 88+ MobileFrontend.utils( document.body ).removeClass( 'full-screen-search' );
8989 var removeResultsEl, pE = document.getElementById( 'placeholder' );
9090
9191 if ( pE ) {
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -174,15 +174,6 @@
175175 top: 35px;
176176 }
177177
178 -#remove-results {
179 - position: absolute;
180 - display: block;
181 - width: 40px;
182 - height: 40px;
183 - text-align: center;
184 - line-height: 40px;
185 -}
186 -
187178 #search {
188179 -webkit-appearance: none;
189180 border-top-width: 0px;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112020use css for the full screen search...jdlrobson16:41, 21 February 2012

Status & tagging log