r112025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112024‎ | r112025 | r112026 >
Date:17:19, 21 February 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
lose focus on click bug and adjust search element and styling for iphone

when you type in the search box and click back the text of the input
is clipped on iphone. This seems to be because Safari adds padding to
default styling.

also fix issue where iphone/safari lose focus on click
on clicking on the search area in safari/iphone the search box
loses focus and the user must click again before typing
this appears to be a glitch in Safari
this can be remedied by changing the search input type from text
to search
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/templates/SearchTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -183,6 +183,7 @@
184184 outline-width: initial;
185185 outline-color: initial;
186186 height: 1.4em;
 187+ padding: 0;
187188 }
188189
189190 ul#footer-info {
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -193,6 +193,7 @@
194194 outline-width: initial;
195195 outline-color: initial;
196196 height: 1.4em;
 197+ padding: 0;
197198 }
198199
199200 ul#footer-info {
Index: trunk/extensions/MobileFrontend/templates/SearchTemplate.php
@@ -33,7 +33,7 @@
3434 <form action='{$scriptUrl}' class='search_bar' method='get' {$searchBoxDisplayNone}>
3535 <input type="hidden" value="Special:Search" name="title" />
3636 <div id="sq" class="divclearable">
37 - <input type="text" name="search" id="search" size="22" value="{$searchField}" autocorrect="off" autocomplete="off" autocapitalize="off" maxlength="1024" />
 37+ <input type="search" name="search" id="search" size="22" value="{$searchField}" autocorrect="off" autocomplete="off" autocapitalize="off" maxlength="1024" />
3838 <div class="clearlink" id="clearsearch"></div>
3939 </div>
4040 <button id='goButton' type='submit'></button>

Status & tagging log