r112007 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112006‎ | r112007 | r112008 >
Date:12:02, 21 February 2012
Author:santhosh
Status:ok
Tags:i18nreview 
Comment:
Minor whitespace and typo fixes. ping r111934
Modified paths:
  • /branches/jsgrammar/resources/mediawiki/mediawiki.jqueryMsg.js (modified) (history)
  • /branches/jsgrammar/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js (modified) (history)

Diff [purge]

Index: branches/jsgrammar/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js
@@ -46,7 +46,7 @@
4747 expect( 5 );
4848 var parser = mw.jqueryMsg.getMessageFunction();
4949 ok( parser, 'Parser Function initialized' );
50 - // Hope the grammar form rammar_case_foo is not valid in any language
 50+ // Hope the grammar form grammar_case_foo is not valid in any language
5151 ok( mw.messages.set( 'grammar-msg', 'Przeszukaj {{GRAMMAR:grammar_case_foo|{{SITENAME}}}}' ), 'mw.messages.set: Register' );
5252 equal( parser( 'grammar-msg' ) , 'Przeszukaj ' + mw.config.get( 'wgSiteName' ) , 'Grammar Test with sitename' );
5353 ok( mw.messages.set( 'grammar-msg-wrong-syntax', 'Przeszukaj {{GRAMMAR:grammar_case_xyz}}' ), 'mw.messages.set: Register' );
Index: branches/jsgrammar/resources/mediawiki/mediawiki.jqueryMsg.js
@@ -672,7 +672,7 @@
673673 grammar: function( nodes ) {
674674 var form = nodes[0];
675675 var word = nodes[1];
676 - return word && form && this.language.convertGrammar( word, form );
 676+ return word && form && this.language.convertGrammar( word, form );
677677 }
678678 };
679679

Sign-offs

UserFlagDate
Nikerabbitinspected14:03, 21 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111934Avoid unconditional modification of original word in fi convertGrammar...santhosh15:09, 20 February 2012

Status & tagging log