r111999 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111998‎ | r111999 | r112000 >
Date:10:22, 21 February 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Close button did not work for the embedded editor for the last item in the table. Bind the close callback to the close input unconditionally.
Modified paths:
  • /trunk/extensions/Translate/resources/ext.translate.quickedit.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/resources/ext.translate.quickedit.js
@@ -87,15 +87,15 @@
8888 callbacks.close && callbacks.close();
8989 callbacks.next && callbacks.next();
9090 } );
91 - form.find( '.mw-translate-close' ).click( function () {
92 - callbacks.close && callbacks.close();
93 - } );
9491 }
9592 } else {
9693 form.find( '.mw-translate-next, .mw-translate-skip' )
9794 .attr( 'disabled', 'disabled' )
9895 .css( 'display', 'none' );
9996 }
 97+ form.find( '.mw-translate-close' ).click( function () {
 98+ callbacks.close && callbacks.close();
 99+ } );
100100
101101 form.find( '.mw-translate-history' ).click( function() {
102102 window.open( mw.util.wikiScript() + '?action=history&title=' + form.find( 'input[name=title]' ).val() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111556Committing my work in embedded translation editor....nikerabbit16:46, 15 February 2012

Status & tagging log