r111940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111939‎ | r111940 | r111941 >
Date:17:20, 20 February 2012
Author:yaron
Status:deferred
Tags:
Comment:
Changed popup link to not include an 'additional query' form in resulting Special:RunQuery page, for the new parser function #queryformlink (which was actually included in the previous revision, r111872, with the wrong comment)
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
@@ -168,6 +168,12 @@
169169 static function renderQueryFormLink ( &$parser ) {
170170 $params = func_get_args();
171171 array_shift( $params ); // We don't need the parser.
 172+ // If it's a popup, take out the "additional query" form
 173+ // in the resulting page, since at the moment those can't
 174+ // be handled anyway.
 175+ if ( in_array( 'popup', $params ) ) {
 176+ $params[] = 'additionalquery=false';
 177+ }
172178
173179 // hack to remove newline from beginning of output, thanks to
174180 // http://jimbojw.com/wiki/index.php?title=Raw_HTML_Output_from_a_MediaWiki_Parser_Function

Sign-offs

UserFlagDate
Nikerabbitinspected07:45, 21 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111872Changed name and ID of free text input from 'free_text' to 'sf_free_text', to...yaron17:06, 19 February 2012