r111931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111930‎ | r111931 | r111932 >
Date:14:16, 20 February 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Whitespace cleanups and change Finnish test case, pastöroitusta would not be a grammatically correct
Modified paths:
  • /branches/jsgrammar/includes/resourceloader/ResourceLoaderLanguageModule.php (modified) (history)
  • /branches/jsgrammar/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js (modified) (history)

Diff [purge]

Index: branches/jsgrammar/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
@@ -8,7 +8,7 @@
99 mw.language.grammartest = function( options ) {
1010 var opt = $.extend({
1111 language: '',
12 - test: [],
 12+ test: []
1313 }, options);
1414 // The test works only if the content language is opt.language
1515 // because it requires [lang].js to be loaded.
@@ -65,7 +65,7 @@
6666 { word: 'գիրք', grammarForm: 'genitive', expected: 'գրքի', description: 'Grammar test for Armenian, genitive case' },
6767 { word: 'ժամանակի', grammarForm: 'genitive', expected: 'ժամանակիի', description: 'Grammar test for Armenian, genitive case' }
6868 ]
69 -});
 69+});
7070
7171 mw.language.grammartest({
7272 language: 'fi',
@@ -73,7 +73,7 @@
7474 { word: 'talo', grammarForm: 'genitive', expected: 'talon', description: 'Grammar test for Finnish, genitive case' },
7575 { word: 'linux', grammarForm: 'genitive', expected: 'linuxin', description: 'Grammar test for Finnish, genitive case' },
7676 { word: 'talo', grammarForm: 'elative', expected: 'talosta', description: 'Grammar test for Finnish, elative case' },
77 - { word: 'pastöroitu', grammarForm: 'elative', expected: 'pastöroitusta', description: 'Grammar test for Finnish, elative case' },
 77+ { word: 'pastöroitu', grammarForm: 'accusative', expected: 'pastöroitua', description: 'Grammar test for Finnish, accusative case' },
7878 { word: 'talo', grammarForm: 'partitive', expected: 'taloa', description: 'Grammar test for Finnish, partitive case' },
7979 { word: 'talo', grammarForm: 'illative', expected: 'taloon', description: 'Grammar test for Finnish, illative case' },
8080 { word: 'linux', grammarForm: 'inessive', expected: 'linuxissa', description: 'Grammar test for Finnish, inessive case' }
Index: branches/jsgrammar/includes/resourceloader/ResourceLoaderLanguageModule.php
@@ -30,9 +30,9 @@
3131 *
3232 * @return Array
3333 */
34 - protected function getSiteLangGrammarForms( ) {
 34+ protected function getSiteLangGrammarForms() {
3535 global $wgContLang;
36 - return $wgContLang->getGrammarForms();
 36+ return $wgContLang->getGrammarForms();
3737 }
3838 /**
3939 * @param $context ResourceLoaderContext

Follow-up revisions

RevisionCommit summaryAuthorDate
r112016The grammar case is partitive and not accusative...santhosh14:27, 21 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111744Russian and Finnish grammar rules in javascript and qunit test cases.santhosh12:13, 17 February 2012

Status & tagging log