r111893 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111892‎ | r111893 | r111894 >
Date:22:29, 19 February 2012
Author:amire80
Status:ok
Tags:i18nreview 
Comment:
Clearer comments.
Modified paths:
  • /branches/jsgrammar/languages/classes/LanguageHe.php (modified) (history)
  • /branches/jsgrammar/resources/mediawiki.language/languages/he.js (modified) (history)

Diff [purge]

Index: branches/jsgrammar/languages/classes/LanguageHe.php
@@ -28,8 +28,8 @@
2929
3030 switch ( $case ) {
3131 case 'prefixed':
32 - case 'תחילית':
33 - # Duplicate the "Waw" if prefixed
 32+ case 'תחילית': // the same word in Hebrew
 33+ # Duplicate prefixed "Waw", but only if it's not already double
3434 if ( substr( $word, 0, 2 ) == "ו" && substr( $word, 0, 4 ) != "וו" ) {
3535 $word = "ו" . $word;
3636 }
@@ -39,7 +39,7 @@
4040 $word = substr( $word, 2 );
4141 }
4242
43 - # Add a hyphen (maqaf) if non-Hebrew letters
 43+ # Add a hyphen (maqaf) before numbers and non-Hebrew letters
4444 if ( substr( $word, 0, 2 ) < "א" || substr( $word, 0, 2 ) > "ת" ) {
4545 $word = "־" . $word;
4646 }
Index: branches/jsgrammar/resources/mediawiki.language/languages/he.js
@@ -20,8 +20,8 @@
2121 }
2222 switch ( form ) {
2323 case 'prefixed':
24 - case 'תחילית':
25 - // Duplicate the "Waw" if prefixed
 24+ case 'תחילית': // the same word in Hebrew
 25+ // Duplicate prefixed "Waw", but only if it's not already double
2626 if ( word.substr( 0, 1 ) === "ו" && word.substr( 0, 2 ) !== "וו" ) {
2727 word = "ו" + word;
2828 }
@@ -31,7 +31,7 @@
3232 word = word.substr( 1, word.length );
3333 }
3434
35 - // Add a hyphen (maqaf) if non-Hebrew letters
 35+ // Add a hyphen (maqaf) before numbers and non-Hebrew letters
3636 if ( word.substr( 0, 1 ) < "א" || word.substr( 0, 1 ) > "ת" ) {
3737 word = "־" + word;
3838 }

Sign-offs

UserFlagDate
Nikerabbitinspected07:31, 20 February 2012

Status & tagging log