r111890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111889‎ | r111890 | r111891 >
Date:21:07, 19 February 2012
Author:siebrand
Status:resolved
Tags:i18nreview 
Comment:
Fix some more stupidity in r111871. Thanks for the help, Niklas.
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -896,13 +896,13 @@
897897
898898 // Allow for adding a custom group description by using
899899 // "MediaWiki:Tp-custom-<group ID>".
900 - if( wfMessage( 'tp-custom-' . $this->id )->inContentLanguage()->exists() ) {
901 - $customText = ' ' . wfMessage( 'tp-custom-' . $this->id )->text();
902 - } else {
903 - $customText = '';
 900+ $customText = '';
 901+ $customMessage = $wfMessage( 'tp-custom-' . $this->id )->inContentLanguage();
 902+ if( $customMessage->exists() ) {
 903+ $customText = $customMessage->plain();
904904 }
905905
906 - return wfMsgNoTrans( 'translate-tag-page-desc', $title, $target ) . $customText;
 906+ return wfMessage( 'translate-tag-page-desc', $title, $target )->plain() . $customText;
907907 }
908908 }
909909

Follow-up revisions

RevisionCommit summaryAuthorDate
r111892Opps, let's not break everythingnikerabbit21:50, 19 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111871Group description of translatable pages can be extended by adding content to ...siebrand16:54, 19 February 2012

Status & tagging log