r111835 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111834‎ | r111835 | r111836 >
Date:17:11, 18 February 2012
Author:dale
Status:deferred
Tags:
Comment:
fixed updated menu interface on source switch
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -1769,6 +1769,13 @@
17701770 $sourceMenu.append(
17711771 $.getLineItem( source.getShortTitle() , icon, function(){
17721772 mw.log( 'PlayerControlBuilder::SwitchSourceMenu: ' + source.getSrc() );
 1773+ // update menu selecting parent li siblings
 1774+ $( this ).parent().siblings().find('span.ui-icon').removeClass( 'ui-icon-bullet').addClass( 'ui-icon-radio-on' );
 1775+ $( this ).find('span.ui-icon').removeClass( 'ui-icon-radio-on').addClass( 'ui-icon-bullet' );
 1776+ // update control bar text
 1777+ embedPlayer.$interface.find( '.source-switch' ).text( source.getShortTitle() );
 1778+
 1779+
17731780 // TODO this logic should be in mw.EmbedPlayer
17741781 embedPlayer.mediaElement.setSource( source );
17751782 if( ! _this.embedPlayer.isStopped() ){

Status & tagging log