r111720 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111719‎ | r111720 | r111721 >
Date:02:24, 17 February 2012
Author:yaron
Status:ok
Tags:
Comment:
Follow-up to r111633 - replaced smwfGetLinker() with equivalent code, to avoid a potentially inconvenient dependency
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
@@ -246,7 +246,7 @@
247247 static function cancelLinkHTML( $is_disabled, $label = null, $attr = array() ) {
248248 global $wgTitle;
249249
250 - $linker = smwfGetLinker();
 250+ $linker = class_exists( 'DummyLinker' ) ? new DummyLinker() : new Linker();
251251 if ( $label == null )
252252 $label = wfMsgExt( 'cancel', array( 'parseinline' ) );
253253 if ( $wgTitle == null )
@@ -259,7 +259,7 @@
260260 } else {
261261 $cancel = $linker->link( $wgTitle, $label, array(), array(), 'known' );
262262 }
263 - $text = " <span class='editHelp'>$cancel</span>\n";
 263+ $text = "\t\t<span class='editHelp'>$cancel</span>\n";
264264 return $text;
265265 }
266266

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111633getSkin is deprecatednikerabbit12:04, 16 February 2012

Status & tagging log