r111710 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111709‎ | r111710 | r111711 >
Date:01:34, 17 February 2012
Author:kaldari
Status:ok
Tags:acw-deploy 
Comment:
changing jquery.ui buttons to match assets from brandon, also adding separate graphics for large buttons
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-hover-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-hover.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-hover-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-hover.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-large-disabled-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-large-off-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-hover-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-hover.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-hover-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-hover.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-large.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-red.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-hover-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-hover-large.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-large.png
___________________________________________________________________
Added: svn:mime-type
22 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-hover.png
___________________________________________________________________
Added: svn:mime-type
33 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-large-off-green.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-large-off-green.png
___________________________________________________________________
Added: svn:mime-type
44 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-large.png
___________________________________________________________________
Added: svn:mime-type
55 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-hover.png
___________________________________________________________________
Added: svn:mime-type
66 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red.png
___________________________________________________________________
Added: svn:mime-type
77 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-hover.png
___________________________________________________________________
Added: svn:mime-type
88 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-hover-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-hover-large.png
___________________________________________________________________
Added: svn:mime-type
99 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue.png
___________________________________________________________________
Added: svn:mime-type
1010 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange-hover.png
___________________________________________________________________
Added: svn:mime-type
1111 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-large-disabled-green.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-large-disabled-green.png
___________________________________________________________________
Added: svn:mime-type
1212 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-hover-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-hover-large.png
___________________________________________________________________
Added: svn:mime-type
1313 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green.png
___________________________________________________________________
Added: svn:mime-type
1414 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-red-large.png
___________________________________________________________________
Added: svn:mime-type
1515 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-hover-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-green-hover-large.png
___________________________________________________________________
Added: svn:mime-type
1616 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-orange.png
___________________________________________________________________
Added: svn:mime-type
1717 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-large.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-blue-large.png
___________________________________________________________________
Added: svn:mime-type
1818 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css
@@ -65,83 +65,130 @@
6666 background: #f2f2f2 url(images/button-disabled.png) repeat-x scroll 50% 100% !important;
6767 }
6868 /* Disables the annoying dashed border Firefox puts on active buttons */
69 -body button.ui-button::-moz-focus-inner {
 69+body button.ui-button::-moz-focus-inner {
7070 border: 0;
7171 }
7272
7373 /* Green buttons */
7474
7575 body .ui-button.ui-button-green {
76 - color: white;
 76+ color: white !important;
7777 border-color: #97af7e !important;
7878 /* @embed */
79 - background: #7acea3 url(images/button-off-green.png) repeat-x scroll 50% 100% !important;
 79+ background: #3cb677 url(images/button-green.png) repeat-x scroll 50% 100% !important;
8080 }
8181 body .ui-button.ui-button-green:hover {
82 - border-color: #778e61;
 82+ border-color: #778e61 !important;
8383 /* @embed */
84 - background: #63c693 url(images/button-over-green.png) repeat-x scroll 50% 100% !important;
 84+ background: #339b65 url(images/button-green-hover.png) repeat-x scroll 50% 100% !important;
8585 }
86 -body .ui-button.ui-button-green:active,
87 -body .ui-button.ui-button-green:focus {
88 - border-color: #61b000;
 86+body .ui-button.ui-button-green-large {
 87+ color: white !important;
 88+ border-color: #97af7e !important;
8989 /* @embed */
90 - background: #63c693 url(images/button-down-green.png) repeat-x scroll 50% 100% !important;
 90+ background: #3cb677 url(images/button-green-large.png) repeat-x scroll 50% 100% !important;
9191 }
92 -body .ui-button.ui-button-green.disabled {
93 - color: #7f7f7f;
94 - border-color: #b8d29f;
 92+body .ui-button.ui-button-green-large:hover {
 93+ border-color: #778e61 !important;
9594 /* @embed */
96 - background: #b3d9c5 url(images/button-disabled-green.png) repeat-x scroll 50% 100% !important;
 95+ background: #339b65 url(images/button-green-hover-large.png) repeat-x scroll 50% 100% !important;
9796 }
 97+body .ui-button.ui-button-green.disabled, body .ui-button.ui-button-green-large.disabled {
 98+ filter:alpha(opacity=50);
 99+ -moz-opacity:0.50;
 100+ -khtml-opacity: 0.50;
 101+ opacity: 0.50;
 102+}
98103
99104 /* Blue buttons */
100105
101106 body .ui-button.ui-button-blue {
102 - color: white;
103 - border-color: #407ec9 !important;
 107+ color: white !important;
 108+ border-color: #628acb !important;
104109 /* @embed */
105 - background: #407ec9 url(images/button-off-blue.png) repeat-x scroll 50% 100% !important;
 110+ background: #3365ba url(images/button-blue.png) repeat-x scroll 50% 100% !important;
106111 }
107112 body .ui-button.ui-button-blue:hover {
108 - border-color: #245289;
 113+ border-color: #5375ad !important;
109114 /* @embed */
110 - background: #4071ad url(images/button-over-blue.png) repeat-x scroll 50% 100% !important;
 115+ background: #2b569e url(images/button-blue-hover.png) repeat-x scroll 50% 100% !important;
111116 }
112 -body .ui-button.ui-button-blue:active,
113 -body .ui-button.ui-button-blue:focus {
114 - border-color: #003980;
 117+body .ui-button.ui-button-blue-large {
 118+ color: white !important;
 119+ border-color: #628acb !important;
115120 /* @embed */
116 - background: #004daa url(images/button-down-blue.png) repeat-x scroll 50% 100% !important;
 121+ background: #3365ba url(images/button-blue-large.png) repeat-x scroll 50% 100% !important;
117122 }
118 -body .ui-button.ui-button-blue.disabled {
119 - border-color: #9eafc6;
 123+body .ui-button.ui-button-blue-large:hover {
 124+ border-color: #5375ad !important;
120125 /* @embed */
121 - background: #c3c8cf url(images/button-disabled-blue.png) repeat-x scroll 50% 100% !important;
 126+ background: #2b569e url(images/button-blue-hover-large.png) repeat-x scroll 50% 100% !important;
122127 }
 128+body .ui-button.ui-button-blue.disabled, body .ui-button.ui-button-blue-large.disabled {
 129+ filter:alpha(opacity=50);
 130+ -moz-opacity:0.50;
 131+ -khtml-opacity: 0.50;
 132+ opacity: 0.50;
 133+}
123134
124135 /* Red buttons */
125136
126137 body .ui-button.ui-button-red {
127 - color: white;
 138+ color: white !important;
128139 border-color: #af977e !important;
129140 /* @embed */
130 - background: #c9404c url(images/button-off-red.png) repeat-x scroll 50% 100% !important;
 141+ background: #cb0000 url(images/button-red.png) repeat-x scroll 50% 100% !important;
131142 }
132143 body .ui-button.ui-button-red:hover {
133 - border-color: #8e7761;
 144+ border-color: #8e7761 !important;
134145 /* @embed */
135 - background: #ad404a url(images/button-over-red.png) repeat-x scroll 50% 100% !important;
 146+ background: #ad0000 url(images/button-red-hover.png) repeat-x scroll 50% 100% !important;
136147 }
137 -body .ui-button.ui-button-red:active,
138 -body .ui-button.ui-button-red:focus {
139 - border-color: #b06100;
 148+body .ui-button.ui-button-red-large {
 149+ color: white !important;
 150+ border-color: #af977e !important;
140151 /* @embed */
141 - background: #aa000f url(images/button-down-red.png) repeat-x scroll 50% 100% !important;
 152+ background: #cb0000 url(images/button-red.png) repeat-x scroll 50% 100% !important;
142153 }
143 -body .ui-button.ui-button-red.disabled {
144 - color: #7f7f7f;
145 - border-color: #c3acae;
 154+body .ui-button.ui-button-red-large:hover {
 155+ border-color: #8e7761 !important;
146156 /* @embed */
147 - background: #cfc3c4 url(images/button-disabled-red.png) repeat-x scroll 50% 100% !important;
 157+ background: #ad0000 url(images/button-red-hover.png) repeat-x scroll 50% 100% !important;
148158 }
 159+body .ui-button.ui-button-red.disabled, body .ui-button.ui-button-red-large.disabled {
 160+ filter:alpha(opacity=50);
 161+ -moz-opacity:0.50;
 162+ -khtml-opacity: 0.50;
 163+ opacity: 0.50;
 164+}
 165+
 166+/* Orange buttons */
 167+
 168+body .ui-button.ui-button-orange {
 169+ color: white !important;
 170+ border-color: #f3a863 !important;
 171+ /* @embed */
 172+ background: #f07f14 url(images/button-orange.png) repeat-x scroll 50% 100% !important;
 173+}
 174+body .ui-button.ui-button-orange:hover {
 175+ border-color: #ce9055 !important;
 176+ /* @embed */
 177+ background: #cc6c11 url(images/button-orange-hover.png) repeat-x scroll 50% 100% !important;
 178+}
 179+body .ui-button.ui-button-orange-large {
 180+ color: white !important;
 181+ border-color: #f3a863 !important;
 182+ /* @embed */
 183+ background: #f07f14 url(images/button-orange-large.png) repeat-x scroll 50% 100% !important;
 184+}
 185+body .ui-button.ui-button-orange-large:hover {
 186+ border-color: #ce9055 !important;
 187+ /* @embed */
 188+ background: #cc6c11 url(images/button-orange-hover-large.png) repeat-x scroll 50% 100% !important;
 189+}
 190+body .ui-button.ui-button-orange.disabled, body .ui-button.ui-button-orange-large.disabled {
 191+ filter:alpha(opacity=50);
 192+ -moz-opacity:0.50;
 193+ -khtml-opacity: 0.50;
 194+ opacity: 0.50;
 195+}

Sign-offs

UserFlagDate
Raindriftinspected22:42, 17 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r111714switching to large button graphics for the large buttons, depends on core cha...kaldari01:56, 17 February 2012

Status & tagging log