r111680 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111679‎ | r111680 | r111681 >
Date:20:50, 16 February 2012
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Bug 34417 - Don't show the button on own userpage

Sorry people, no self love in public, kthx
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.hooks.php
——@@ -187,6 +187,10 @@
188188 return null;
189189 }
190190
 191+ if ( $wgUser->getName() == $baseTitle->getText() ) {
 192+ return null;
 193+ }
 194+
191195 // Get the user talk page
192196 if ( $ns == NS_USER_TALK ) {
193197 // We're already on the user talk page

Follow-up revisions

RevisionCommit summaryAuthorDate
r111970Change for ===...reedy21:57, 20 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   06:52, 17 February 2012

Eww ==. 

> var_dump( "0" == "0000" );
bool(true)
#Comment by Hashar (talk | contribs)   09:54, 29 February 2012

This will block Bug 2119 - Allow full caching of all HTML, even for logged in users since it fragments HTML cache for user pages :-/

Marking OK nonetheless cause we are nowhere near enabling caching for logged in users.

Status & tagging log