r111618 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111617‎ | r111618 | r111619 >
Date:04:08, 16 February 2012
Author:tstarling
Status:ok
Tags:
Comment:
* Instantiate the "db" global variable in the normal way, instead of attempting to compile a header file, which just makes gcc generate a pre-compiled header (*.gch). Presumably that's not what was intended, and it causes a fatal error in my lucid chroot due to some detail.
* Updated changelog.
Modified paths:
  • /trunk/udpprofile/Makefile (modified) (history)
  • /trunk/udpprofile/debian/changelog (modified) (history)
  • /trunk/udpprofile/export.c (modified) (history)

Diff [purge]

Index: trunk/udpprofile/Makefile
@@ -10,9 +10,9 @@
1111
1212 all: collector exporter
1313
14 -collector: collector.h collector.c export.c
 14+collector: collector.c export.c
1515
16 -exporter: export.c collector.h exporter.c
 16+exporter: export.c exporter.c
1717
1818 #export: collector.h export.c
1919
Index: trunk/udpprofile/debian/changelog
@@ -1,3 +1,9 @@
 2+udpprofile (1.3-1) lucid-wikimedia; urgency=low
 3+
 4+ * Added automatic aggregation across DBs to collector
 5+
 6+ -- Tim Starling <tstarling@wikimedia.org> Thu, 16 Feb 2012 14:46:14 +1100
 7+
28 udpprofile (1.2-2) lucid-wikimedia; urgency=low
39
410 * exception handing in profiler-to-carbon, for when collector has no data
Index: trunk/udpprofile/export.c
@@ -17,6 +17,8 @@
1818 #include <db.h>
1919 #include "collector.h"
2020
 21+DB *db;
 22+
2123 void dumpData(FILE *fd) {
2224 DBT key,data;
2325 DBC *c;

Status & tagging log