r111449 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111448‎ | r111449 | r111450 >
Date:07:25, 14 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Reverted r111186, r111226: broken per CR
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/includes/ChangeTags.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -114,7 +114,6 @@
115115 * Harry Burt
116116 * Ireas
117117 * Jaska Zedlik
118 -* Jarry1250
119118 * Jeremy Baron
120119 * Jidanni
121120 * Jimmy Xu
Index: trunk/phase3/includes/ChangeTags.php
@@ -209,8 +209,8 @@
210210 if ( !$wgUseTagFilter || !count( self::listDefinedTags() ) )
211211 return $fullForm ? '' : array();
212212
213 - $data = array( Html::rawElement( 'label', array( 'for' => 'tagfilter' ), wfMsgExt( 'tag-filter', 'parseinline' ),
214 - Xml::input( 'tagfilter', 20, $selected, array( 'class' => 'tagfilter-input' ) ) ) );
 213+ $data = array( Html::rawElement( 'label', array( 'for' => 'tagfilter' ), wfMsgExt( 'tag-filter', 'parseinline' ) ),
 214+ Xml::input( 'tagfilter', 20, $selected ) );
215215
216216 if ( !$fullForm ) {
217217 return $data;
@@ -219,7 +219,7 @@
220220 $html = implode( ' ', $data );
221221 $html .= "\n" . Xml::element( 'input', array( 'type' => 'submit', 'value' => wfMsg( 'tag-filter-submit' ) ) );
222222 $html .= "\n" . Html::hidden( 'title', $title->getPrefixedText() );
223 - $html = Xml::tags( 'form', array( 'action' => $title->getLocalURL(), 'class' => 'tagfilter-form', 'method' => 'get' ), $html );
 223+ $html = Xml::tags( 'form', array( 'action' => $title->getLocalURL(), 'method' => 'get' ), $html );
224224
225225 return $html;
226226 }
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -568,14 +568,14 @@
569569 $submit = ' ' . Xml::submitbutton( wfMsg( 'allpagessubmit' ) );
570570
571571 $out = Xml::openElement( 'table', array( 'class' => 'mw-recentchanges-table' ) );
572 - foreach( $extraOpts as $name=>$optionRow ) {
 572+ foreach( $extraOpts as $optionRow ) {
573573 # Add submit button to the last row only
574574 ++$count;
575 - $addSubmit = ( $count === $extraOptsCount ) ? $submit : '';
 575+ $addSubmit = $count === $extraOptsCount ? $submit : '';
576576
577577 $out .= Xml::openElement( 'tr' );
578578 if( is_array( $optionRow ) ) {
579 - $out .= Xml::tags( 'td', array( 'class' => 'mw-label ' . $name . '-label' ), $optionRow[0] );
 579+ $out .= Xml::tags( 'td', array( 'class' => 'mw-label' ), $optionRow[0] );
580580 $out .= Xml::tags( 'td', array( 'class' => 'mw-input' ), $optionRow[1] . $addSubmit );
581581 } else {
582582 $out .= Xml::tags( 'td', array( 'class' => 'mw-input', 'colspan' => 2 ), $optionRow . $addSubmit );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111186Fixes Bug 18704 - Add an unique CSS class or ID to the tagfilter table row at...mah19:29, 10 February 2012
r111226re r111186: remove extra form tag.mah01:53, 11 February 2012

Status & tagging log