r111411 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111410‎ | r111411 | r111412 >
Date:20:16, 13 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Tabs seems to upset mysql
Modified paths:
  • /trunk/extensions/GlobalBlocking/GlobalBlocking.class.php (modified) (history)
  • /trunk/extensions/GlobalBlocking/globalblocking.sql (modified) (history)
  • /trunk/extensions/GlobalBlocking/localdb_patches/setup-global_block_whitelist.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/GlobalBlocking.class.php
@@ -36,6 +36,8 @@
3737 }
3838
3939 /**
 40+ * @param $user User
 41+ * @param $ip
4042 * @return Array: empty or a message key with parameters
4143 */
4244 static function getUserBlockErrors( $user, $ip ) {
Index: trunk/extensions/GlobalBlocking/globalblocking.sql
@@ -9,7 +9,7 @@
1010 gb_expiry varbinary(14) NOT NULL default '',
1111 gb_range_start varbinary(32) NOT NULL, -- Needs 32, not 8 for IPv6 support
1212 gb_range_end varbinary(32) NOT NULL,
13 -
 13+
1414 PRIMARY KEY gb_id (gb_id),
1515
1616 UNIQUE INDEX gb_address (gb_address, gb_anon_only),
Index: trunk/extensions/GlobalBlocking/localdb_patches/setup-global_block_whitelist.sql
@@ -4,10 +4,10 @@
55 CREATE TABLE /*$wgDBprefix*/global_block_whitelist (
66 gbw_id int(11) NOT NULL, -- Key to gb_id in globalblocks database.
77 gbw_address varbinary(255) NOT NULL,
8 - gbw_by int(11) NOT NULL, -- Key to user_id
 8+ gbw_by int(11) NOT NULL, -- Key to user_id
99 gbw_by_text varchar(255) NOT NULL,
1010 gbw_reason varchar(255) NOT NULL,
1111 gbw_expiry binary(14) NOT NULL,
1212 PRIMARY KEY (gbw_id),
1313 KEY (gbw_by)
14 -) /*$wgDBTableOptions*/;
\ No newline at end of file
 14+) /*$wgDBTableOptions*/;

Status & tagging log