r111384 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111383‎ | r111384 | r111385 >
Date:16:22, 13 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Followup r111199

Mixed usage of $m/$matches in PagedTiffHandler_body.php
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -710,7 +710,7 @@
711711 }
712712 // Check if the parameters can be extracted from the thumbnail name...
713713 if ( preg_match( '!^(lossy|lossless)-page(\d+)-(\d+)px-[^/]*$!', $thumbname, $m ) ) {
714 - list( /* all */, $lossy, $pagenum, $size ) = $matches;
 714+ list( /* all */, $lossy, $pagenum, $size ) = $m;
715715 $params['lossy'] = $lossy;
716716 $params['width'] = $size;
717717 $params['page'] = $pagenum;

Follow-up revisions

RevisionCommit summaryAuthorDate
r111385MFT r111199reedy16:28, 13 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111199* Removed thumb.php comment about ProofreadPage, page numbers are more general....aaron20:52, 10 February 2012

Status & tagging log