r111338 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111337‎ | r111338 | r111339 >
Date:23:42, 12 February 2012
Author:robin
Status:ok
Tags:
Comment:
add warning note to isKnown() per r111017
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -4180,6 +4180,9 @@
41814181 * viewed? In particular, this function may be used to determine if
41824182 * links to the title should be rendered as "bluelinks" (as opposed to
41834183 * "redlinks" to non-existent pages).
 4184+ * Adding something else to this function will cause inconsistency
 4185+ * since LinkHolderArray calls isAlwaysKnown() and does its own
 4186+ * page existence check.
41844187 *
41854188 * @return Bool
41864189 */

Sign-offs

UserFlagDate
Nikerabbitinspected07:20, 13 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111017put in r110285 again now that 1.19 branchedjeroendedauw01:34, 9 February 2012

Status & tagging log