r111317 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111316‎ | r111317 | r111318 >
Date:19:18, 12 February 2012
Author:ialex
Status:ok
Tags:
Comment:
Added missing directories to findHooks.php and missing quote in hooks.txt that made LoginAuthenticateAudit show up as undocumented when running findHooks.php
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/maintenance/findHooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/findHooks.php
@@ -63,8 +63,10 @@
6464 $IP . '/includes/db/',
6565 $IP . '/includes/diff/',
6666 $IP . '/includes/filerepo/',
 67+ $IP . '/includes/filerepo/file/',
6768 $IP . '/includes/installer/',
6869 $IP . '/includes/interwiki/',
 70+ $IP . '/includes/logging/',
6971 $IP . '/includes/media/',
7072 $IP . '/includes/parser/',
7173 $IP . '/includes/resourceloader/',
Index: trunk/phase3/docs/hooks.txt
@@ -1238,7 +1238,7 @@
12391239 - 'comment' Wikitext string in the same format as an edit summary
12401240 - 'timestamp' Timestamp when the action occured
12411241
1242 -LoginAuthenticateAudit': a login attempt for a valid user account either
 1242+'LoginAuthenticateAudit': a login attempt for a valid user account either
12431243 succeeded or failed. No return data is accepted; this hook is for auditing only.
12441244 $user: the User object being authenticated against
12451245 $password: the password being submitted and found wanting

Sign-offs

UserFlagDate
Nikerabbitinspected07:04, 13 February 2012

Status & tagging log