r111311 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111310‎ | r111311 | r111312 >
Date:18:11, 12 February 2012
Author:jeroendedauw
Status:ok
Tags:
Comment:
Follow up to r111309; fix if condition and style fix
Modified paths:
  • /trunk/phase3/includes/DBDataObject.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DBDataObject.php
@@ -207,7 +207,7 @@
208208 array( 'LIMIT' => 1 )
209209 );
210210
211 - if ( !$result ) {
 211+ if ( $result !== false ) {
212212 $this->setFields( $this->getFieldsFromDBResult( $result ), $override );
213213 return true;
214214 }
@@ -880,7 +880,8 @@
881881 }
882882
883883 $dbr = wfGetDB( static::getReadDb() );
884 - $result = $dbr->select(static::getDBTable(),
 884+ $result = $dbr->select(
 885+ static::getDBTable(),
885886 static::getPrefixedFields( $fields ),
886887 static::getPrefixedValues( $conditions ),
887888 __METHOD__,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111309Convert rawSelect() into rawSelectRow()...platonides17:36, 12 February 2012

Status & tagging log