r111270 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111269‎ | r111270 | r111271 >
Date:23:46, 11 February 2012
Author:wikinaut
Status:ok
Tags:
Comment:
Aashish's fix for bug33997 (SpecialPasswordReset does not always has the correct returnto= page on the login / create account portlet and returns to SpecialPasswortReset instead to Main page )
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -133,9 +133,13 @@
134134 }
135135 $wgAuth->setDomain( $this->mDomain );
136136
137 - # When switching accounts, it sucks to get automatically logged out
 137+ # 1. When switching accounts, it sucks to get automatically logged out
 138+ # 2. Do not return to PasswordReset after a successful password change
 139+ # but goto Wiki start page (Main_Page) instead ( bug 33997 )
138140 $returnToTitle = Title::newFromText( $this->mReturnTo );
139 - if( is_object( $returnToTitle ) && $returnToTitle->isSpecial( 'Userlogout' ) ) {
 141+ if( is_object( $returnToTitle ) && (
 142+ $returnToTitle->isSpecial( 'Userlogout' )
 143+ || $returnToTitle->isSpecial( 'PasswordReset' ) ) ) {
140144 $this->mReturnTo = '';
141145 $this->mReturnToQuery = '';
142146 }

Status & tagging log