r111258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111257‎ | r111258 | r111259 >
Date:20:13, 11 February 2012
Author:dale
Status:deferred
Tags:
Comment:
renamed pre post sequence flags to include the word "flag" to not conflict with triggered events and jquery's lose type checking on triggered events .
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -825,7 +825,7 @@
826826 * On clip done action. Called once a clip is done playing
827827 * TODO clean up end sequence flow
828828 */
829 - postSequence: false,
 829+ postSequenceFlag: false,
830830 onClipDone: function() {
831831 var _this = this;
832832 // Don't run onclipdone if _propagateEvents is off
@@ -1251,8 +1251,8 @@
12521252
12531253 // Reset first play to true, to count that play event
12541254 this.firstPlay = true;
1255 - this.preSequence = false;
1256 - this.postSequence = false;
 1255+ this.preSequenceFlag = false;
 1256+ this.postSequenceFlag = false;
12571257
12581258 // Add a loader to the embed player:
12591259 this.pauseLoading();
@@ -1675,7 +1675,7 @@
16761676 * Updates pause button Starts the "monitor"
16771677 */
16781678 firstPlay : true,
1679 - preSequence: false,
 1679+ preSequenceFlag: false,
16801680 inPreSequence: false,
16811681 replayEventCount : 0,
16821682 play: function() {
@@ -1696,8 +1696,8 @@
16971697 }
16981698 }
16991699
1700 - if( !this.preSequence ) {
1701 - this.preSequence = true;
 1700+ if( !this.preSequenceFlag ) {
 1701+ this.preSequenceFlag = true;
17021702 mw.log( "EmbedPlayer:: trigger preSequence " );
17031703 $( this ).trigger( 'preSequence' );
17041704 this.playInterfaceUpdate();

Status & tagging log