r111195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111194‎ | r111195 | r111196 >
Date:20:28, 10 February 2012
Author:mah
Status:ok
Tags:
Comment:
fixes Bug 26459 - The renderNavigation and renderPortals functions should be protected or public instead of private
Patch from Christian Neubauer
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -250,7 +250,7 @@
251251 *
252252 * @param $portals array
253253 */
254 - private function renderPortals( $portals ) {
 254+ protected function renderPortals( $portals ) {
255255 // Force the rendering of the following portals
256256 if ( !isset( $portals['SEARCH'] ) ) {
257257 $portals['SEARCH'] = true;
@@ -292,7 +292,7 @@
293293 * @param $msg null|string
294294 * @param $hook null|string|array
295295 */
296 - private function renderPortal( $name, $content, $msg = null, $hook = null ) {
 296+ protected function renderPortal( $name, $content, $msg = null, $hook = null ) {
297297 if ( $msg === null ) {
298298 $msg = $name;
299299 }
@@ -330,7 +330,7 @@
331331 *
332332 * @param $elements array
333333 */
334 - private function renderNavigation( $elements ) {
 334+ protected function renderNavigation( $elements ) {
335335 global $wgVectorUseSimpleSearch;
336336
337337 // If only one element was given, wrap it in an array, allowing more
Index: trunk/phase3/CREDITS
@@ -95,6 +95,7 @@
9696 * Brianna Laugher
9797 * Carlin
9898 * Carsten Nielsen
 99+* Christian Neubauer
99100 * Conrad Irwin
100101 * cryptocoryne
101102 * Dan Barrett

Status & tagging log