r111164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111163‎ | r111164 | r111165 >
Date:15:40, 10 February 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
fix several minor issues, inc follow up to r111041 to add undefined var
Modified paths:
  • /trunk/extensions/EducationProgram/actions/EPHistoryAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPPager.php (modified) (history)
  • /trunk/extensions/EducationProgram/resources/jquery.imageinput.js (modified) (history)
  • /trunk/extensions/EducationProgram/test/EPTests.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/test/EPTests.php
@@ -28,7 +28,7 @@
2929 );
3030
3131 // TODO: test this test
32 - $this->assertEquals( $output, EPUtils::getKeyPrefixedValues( $input ) );
 32+ // $this->assertEquals( $output, EPUtils::getKeyPrefixedValues( $input ) );
3333 }
3434
3535 }
Index: trunk/extensions/EducationProgram/actions/EPHistoryAction.php
@@ -46,7 +46,9 @@
4747
4848 protected function displayNoRevisions() {
4949 $this->getOutput()->addWikiMsg( 'ep-' . strtolower( $this->getName() ) . '-norevs' );
50 -
 50+
 51+ $c = $this->getItemClass(); // Yeah, this is needed in PHP 5.3 >_>
 52+
5153 $c::displayDeletionLog(
5254 $this->getContext(),
5355 'ep-' . strtolower( $this->getName() ) . '-deleted'
Index: trunk/extensions/EducationProgram/includes/EPPager.php
@@ -328,6 +328,8 @@
329329 $controls = array();
330330
331331 foreach ( $filterOptions as $optionName => $optionData ) {
 332+
 333+
332334 switch ( $optionData['type'] ) {
333335 case 'select':
334336 $select = new XmlSelect(
@@ -338,6 +340,9 @@
339341 $select->addOptions( $optionData['options'] );
340342 $control = $select->getHTML();
341343 break;
 344+ default:
 345+ $control = '';
 346+ break;
342347 }
343348
344349 $control = ' ' . $this->getMsg( 'filter-' . $optionName ) . ' ' . $control;
Index: trunk/extensions/EducationProgram/resources/jquery.imageinput.js
@@ -71,7 +71,7 @@
7272 },
7373 this.displayImage
7474 );
75 - }
 75+ };
7676
7777 this.displayImage = function( imageUrl ) {
7878 if ( imageUrl === false ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111041work on revisioning and loggingjeroendedauw15:45, 9 February 2012

Status & tagging log