r111044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111043‎ | r111044 | r111045 >
Date:17:09, 9 February 2012
Author:yonishostak
Status:ok
Tags:aft, nodeploy 
Comment:
AFTv5: fix bug 34072 - tools label for auth users
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -70,7 +70,11 @@
7171 #bodyContent h2 {
7272 clear: both;
7373 }
 74+#articleFeedbackv5-sort {
 75+ width: 300px;
 76+}
7477 #articleFeedbackv5-filter {
 78+ float: left;
7579 font-size: 1.125em;
7680 }
7781 #articleFeedbackv5-sort-filter-controls {
@@ -95,6 +99,14 @@
96100 float: none;
97101 display: inline-block;
98102 }
 103+#articleFeedbackv5-tools-label {
 104+ float: right;
 105+ top: 0;
 106+ right: 150;
 107+ font-size: 1.125em;
 108+ width: 140px;
 109+}
 110+
99111 #articleFeedbackv5-show-feedback {
100112 min-height: 250px;
101113 }
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -282,10 +282,18 @@
283283 . $filterSelect->getHTML()
284284 . $this->msg( 'articlefeedbackv5-special-filter-label-after' )->escaped()
285285 . Html::closeElement( 'div' )
286 -
287 -
 286+ );
 287+ if( $wgUser->isAllowed( 'aftv5-delete-feedback' ) || $wgUser->isAllowed( 'aftv5-hide-feedback' ) ) {
 288+ $out->addHTML(
 289+ Html::openElement(
 290+ 'div',
 291+ array( 'id' => 'articleFeedbackv5-tools-label' )
 292+ )
 293+ . $this->msg( 'articlefeedbackv5-form-tools-label' )->escaped()
288294 . Html::closeElement( 'div' )
289 - );
 295+ );
 296+ }
 297+ $out->addHTML( Html::closeElement( 'div' ) );
290298
291299 $out->addHTML(
292300 Html::element(

Status & tagging log