r110934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110933‎ | r110934 | r110935 >
Date:14:30, 8 February 2012
Author:hashar
Status:ok
Tags:
Comment:
rtrim() call does not pass by reference!

fix r110923
Modified paths:
  • /trunk/phase3/includes/filerepo/backend/FSFileBackend.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/FSFileBackend.php
@@ -51,7 +51,7 @@
5252 if( isset( $config['containerPaths'] ) ) {
5353 $this->containerPaths = (array)$config['containerPaths'];
5454 foreach ( $this->containerPaths as &$path ) {
55 - rtrim( $path, '/' ); // remove trailing slash
 55+ $path = rtrim( $path, '/' ); // remove trailing slash
5656 }
5757 }
5858

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110923use rtrim() to strip trailing slashes...hashar09:16, 8 February 2012

Status & tagging log