r110921 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110920‎ | r110921 | r110922 >
Date:08:20, 8 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Backported stats query index usage fixes (r98569) from /trunk
Modified paths:
  • /branches/REL1_18/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php
@@ -309,8 +309,9 @@
310310 array( 'rev_user' => 0, $timeCondition, "(rev_id % $mod) = 0" ),
311311 __METHOD__,
312312 array(
313 - 'GROUP BY' => 'rev_id',
314 - 'USE INDEX' => array( 'p' => 'PRIMARY', 'n' => 'PRIMARY' )
 313+ 'GROUP BY' => array( 'rev_timestamp', 'rev_id' ), // user_timestamp INDEX used
 314+ 'USE INDEX' => array( 'revision' => 'user_timestamp' ), // sanity; mysql picks this
 315+ 'STRAIGHT_JOIN'
315316 ),
316317 array(
317318 'p' => array( 'INNER JOIN', array( // last review

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98569Fixed totally broken query plan for anon edit stats....aaron21:31, 30 September 2011

Status & tagging log