r110916 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110915‎ | r110916 | r110917 >
Date:07:03, 8 February 2012
Author:hashar
Status:ok
Tags:
Comment:
make gzopen() portable by using binary flag

r110871 forgot the 'b' flag which make sure gzopen handle file
content in binary form. That is for portability accross platforms.
Modified paths:
  • /trunk/phase3/includes/cache/FileCacheBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/FileCacheBase.php
——@@ -117,7 +117,7 @@
118118 */
119119 public function fetchText() {
120120 // gzopen can transparently read from gziped or plain text
121 - $fh = gzopen( $this->cachePath(), 'r' );
 121+ $fh = gzopen( $this->cachePath(), 'rb' );
122122 return stream_get_contents( $fh );
123123 }
124124

Sign-offs

UserFlagDate
Nikerabbitinspected21:23, 8 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110871simplify FileCacheBase::fetchText...hashar20:47, 7 February 2012

Status & tagging log