r110910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110909‎ | r110910 | r110911 >
Date:05:25, 8 February 2012
Author:tstarling
Status:ok
Tags:
Comment:
Fixed a bug in User::loadOptions(), probably introduced in r49925, causing the User::loadOptions() query to be done after a cache load if the user had no option overrides at the time of cache save. Store an empty array to the cache's mOptionOverrides instead of null.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
——@@ -3997,6 +3997,7 @@
39983998 __METHOD__
39993999 );
40004000
 4001+ $this->mOptionOverrides = array();
40014002 foreach ( $res as $row ) {
40024003 $this->mOptionOverrides[$row->up_property] = $row->up_value;
40034004 $this->mOptions[$row->up_property] = $row->up_value;

Sign-offs

UserFlagDate
Nikerabbitinspected21:18, 8 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49925Fix problem where cached user objects would not update when default user opti...werdna03:51, 27 April 2009

Status & tagging log