r110878 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110877‎ | r110878 | r110879 >
Date:22:00, 7 February 2012
Author:diederik
Status:deferred
Tags:
Comment:
Updated IP blocks that should be filtered due to duplicate squid requests.
Modified paths:
  • /trunk/webstatscollector/filter.c (modified) (history)

Diff [purge]

Index: trunk/webstatscollector/filter.c
@@ -57,13 +57,24 @@
5858 return false;
5959 }
6060
61 -/* IP addresses from which duplicate requests originate */
 61+/* IP addresses from which duplicate requests originate
 62+* Correspondence with Mark Bergsma on IRC.
 63+* diederik: what is exactly the issue?
 64+* mark: squids requesting from eachother
 65+* diederik: 1) is this still an issue (mentioned on line 60)?
 66+* mark: only 208.80. and 91.198.174 are still relevant
 67+* removed IP blocks:
 68+* "145.97.39.",
 69+* "66.230.200.",
 70+* "211.115.107.",
 71+*/
6272
63 -char *dupes[] = {"145.97.39.","66.230.200.",
64 - "208.80.152.","208.80.153.",
65 - "208.80.154.","208.80.155.",
66 - "211.115.107.","91.198.174.",
67 - NULL};
 73+char *dupes[] = {"208.80.152.",
 74+ "208.80.153.",
 75+ "208.80.154.",
 76+ "208.80.155.",
 77+ "91.198.174.",
 78+ NULL};
6879
6980 bool check_ip(char *ip) {
7081 char **prefix=dupes;

Status & tagging log