r110856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110855‎ | r110856 | r110857 >
Date:16:49, 7 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Merge r97508 changes to MessageCache.php and Skin.php into trunk
Modified paths:
  • /trunk/phase3 (modified) (history)
  • /trunk/phase3/includes (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/cache/MessageCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/MessageCache.php
@@ -499,10 +499,10 @@
500500 $codes = array_keys( Language::getLanguageNames() );
501501 }
502502
503 - global $parserMemc;
 503+ global $wgMemc;
504504 foreach ( $codes as $code ) {
505505 $sidebarKey = wfMemcKey( 'sidebar', $code );
506 - $parserMemc->delete( $sidebarKey );
 506+ $wgMemc->delete( $sidebarKey );
507507 }
508508
509509 // Update the message in the message blob store
Property changes on: trunk/phase3/includes/cache/MessageCache.php
___________________________________________________________________
Modified: svn:mergeinfo
510510 Merged /branches/wmf/1.18wmf1/includes/cache/MessageCache.php:r97508
Index: trunk/phase3/includes/Skin.php
@@ -1178,13 +1178,13 @@
11791179 * @return array
11801180 */
11811181 function buildSidebar() {
1182 - global $parserMemc, $wgEnableSidebarCache, $wgSidebarCacheExpiry;
 1182+ global $wgMemc, $wgEnableSidebarCache, $wgSidebarCacheExpiry;
11831183 wfProfileIn( __METHOD__ );
11841184
11851185 $key = wfMemcKey( 'sidebar', $this->getLanguage()->getCode() );
11861186
11871187 if ( $wgEnableSidebarCache ) {
1188 - $cachedsidebar = $parserMemc->get( $key );
 1188+ $cachedsidebar = $wgMemc->get( $key );
11891189 if ( $cachedsidebar ) {
11901190 wfProfileOut( __METHOD__ );
11911191 return $cachedsidebar;
@@ -1196,7 +1196,7 @@
11971197
11981198 wfRunHooks( 'SkinBuildSidebar', array( $this, &$bar ) );
11991199 if ( $wgEnableSidebarCache ) {
1200 - $parserMemc->set( $key, $bar, $wgSidebarCacheExpiry );
 1200+ $wgMemc->set( $key, $bar, $wgSidebarCacheExpiry );
12011201 }
12021202
12031203 wfProfileOut( __METHOD__ );
Property changes on: trunk/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
12041204 Merged /branches/wmf/1.18wmf1/includes:r97508
Property changes on: trunk/phase3
___________________________________________________________________
Modified: svn:mergeinfo
12051205 Merged /branches/wmf/1.18wmf1:r97508

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r975081.18wmf1, Merge r96552, r96835reedy15:35, 19 September 2011

Status & tagging log