r110793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110792‎ | r110793 | r110794 >
Date:21:52, 6 February 2012
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r110761: removed duplicate check of $wgShowIPinHeader and fix some whitespaces
Modified paths:
  • /trunk/phase3/includes/cache/HTMLFileCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/HTMLFileCache.php
@@ -65,8 +65,8 @@
6666 if ( !$wgUseFileCache ) {
6767 return false;
6868 }
69 - if( $wgShowIPinHeader || $wgDebugToolbar ) {
70 - wfDebug("HTML file cache skipped. Either \$wgShowIPinHeader and/or \$wgDebugToolbar on\n" );
 69+ if ( $wgShowIPinHeader || $wgDebugToolbar ) {
 70+ wfDebug( "HTML file cache skipped. Either \$wgShowIPinHeader and/or \$wgDebugToolbar on\n" );
7171 return false;
7272 }
7373
@@ -90,7 +90,7 @@
9191 $ulang = $context->getLanguage()->getCode();
9292 $clang = $wgContLang->getCode();
9393 // Check that there are no other sources of variation
94 - return !$wgShowIPinHeader && !$user->getId() && !$user->getNewtalk() && $ulang == $clang;
 94+ return !$user->getId() && !$user->getNewtalk() && $ulang == $clang;
9595 }
9696
9797 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110761disable wgDebugToolbar when rebuilding file cache...hashar17:17, 6 February 2012

Status & tagging log