r110775 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110774‎ | r110775 | r110776 >
Date:20:18, 6 February 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
do not let other stuff add adittional tabs. Although this might be usefull, its far less likely then other stuff adding tabs assuming they are for regular pages and so have non functioning actions
Modified paths:
  • /trunk/extensions/EducationProgram/EducationProgram.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/EducationProgram.hooks.php
@@ -171,12 +171,12 @@
172172 * @param SkinTemplate $sktemplate
173173 * @param array $links
174174 *
175 - * @return true
 175+ * @return false
176176 */
177177 public static function onPageTabs( SkinTemplate &$sktemplate, array &$links ) {
178178 self::displayTabs( $sktemplate, $links, $sktemplate->getTitle() );
179179
180 - return true;
 180+ return false;
181181 }
182182
183183 /**
@@ -188,7 +188,7 @@
189189 * @param SkinTemplate $sktemplate
190190 * @param array $links
191191 *
192 - * @return true
 192+ * @return false
193193 */
194194 public static function onSpecialPageTabs( SkinTemplate &$sktemplate, array &$links ) {
195195 $textParts = SpecialPageFactory::resolveAlias( $sktemplate->getTitle()->getText() );
@@ -212,7 +212,7 @@
213213 }
214214 }
215215
216 - return true;
 216+ return false;
217217 }
218218
219219 /**

Status & tagging log