r110729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110728‎ | r110729 | r110730 >
Date:21:00, 5 February 2012
Author:wikinaut
Status:deferred
Tags:
Comment:
since we already use jQuery we can use jQuery closure for the redirect
Modified paths:
  • /trunk/extensions/OpenID/OpenID.php (modified) (history)
  • /trunk/extensions/OpenID/README.OpenID-mediawiki-extension (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenID.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/README.OpenID-mediawiki-extension
@@ -1,5 +1,5 @@
22 MediaWiki OpenID extension README.OpenID-mediawiki-extension file
3 -version 0.946-beta 20120201
 3+version 0.947-beta 20120205
44 Homepage and manual http://www.mediawiki.org/wiki/Extension:OpenID
55
66 Please check OpenID.setup.php for the current program version number
@@ -466,6 +466,7 @@
467467 into that account now
468468
469469 == CHANGES ==
 470+* 0.947 using jQuery closure for redirect
470471 * 0.946 fixed the problem of broken automatic redirect to OpenID provider login
471472 replaced hookEvent() by jQuery( document ).ready( submitOpenIDForm )
472473 * 0.945 improved Makefile: added the SHA1 checksum of php-openid library.tar.gz
Index: trunk/extensions/OpenID/SpecialOpenID.body.php
@@ -291,7 +291,9 @@
292292 } else {
293293 $wgOut->addWikiMsg( 'openidautosubmit' );
294294 $wgOut->addHTML( $form_html );
295 - $wgOut->addInlineScript( "function submitOpenIDForm() {\n document.getElementById(\"" . $form_id . "\").submit()\n};\njQuery( document ).ready( submitOpenIDForm );\n");
 295+ $wgOut->addInlineScript(
 296+ "jQuery( document ).ready( function(){ jQuery( \"#" . $form_id . "\" ).submit() } );"
 297+ );
296298 }
297299 }
298300
Index: trunk/extensions/OpenID/OpenID.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.946-beta 20120201' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.947-beta 20120205' );
3232
3333 $path = dirname( __FILE__ );
3434 set_include_path( implode( PATH_SEPARATOR, array( $path ) ) . PATH_SEPARATOR . get_include_path() );

Status & tagging log