r110608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110607‎ | r110608 | r110609 >
Date:20:16, 2 February 2012
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Bring the epocs into this decade
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -760,7 +760,7 @@
761761 * Update if there is some need to force thumbs and SVG rasterizations
762762 * to rerender, such as fixes to rendering bugs.
763763 */
764 -$wgThumbnailEpoch = '20030516000000';
 764+$wgThumbnailEpoch = '20110101000000';
765765
766766 /**
767767 * If set, inline scaled images will still produce <img> tags ready for
——@@ -1683,7 +1683,7 @@
16841684 * You can get the current date on your server by using the command:
16851685 * date +%Y%m%d%H%M%S
16861686 */
1687 -$wgCacheEpoch = '20030516000000';
 1687+$wgCacheEpoch = '20110101000000';
16881688
16891689 /**
16901690 * Bump this number when changing the global style sheets and JavaScript.

Follow-up revisions

RevisionCommit summaryAuthorDate
r110623Reverted r110608 - no known need for thisaaron22:05, 2 February 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   20:19, 2 February 2012

Is there a reason for this change?

#Comment by Reedy (talk | contribs)   20:22, 2 February 2012

Changes in thumbnailing and parsing means they should be re-rendered

Having the value set 9 years ago means even with an upgrade of MW, ancient versions can still be used, and won't get regenerated unless newer versions come in, or the user explicitly updates the epochs themselves

#Comment by Aaron Schulz (talk | contribs)   20:27, 2 February 2012

Right, was there a specific change that this needed to be bumped for (maybe were someone forgot)? It's probably OK, but it seems to have some risk for little gain.

#Comment by Dantman (talk | contribs)   20:32, 2 February 2012

Does this have any purpose? I see no reason to invalidate old items like this when the local wiki hasn't done the invalidation.

#Comment by Reedy (talk | contribs)   14:38, 6 February 2012

Hell, this will do even less "damage" on 3rd party wikis that have done any sort of LocalSettings in the last decade 

if ( $wgInvalidateCacheOnLocalSettingsChange ) {
	$wgCacheEpoch = max( $wgCacheEpoch, gmdate( 'YmdHis', @filemtime( "$IP/LocalSettings.php" ) ) );
}

wgInvalidateCacheOnLocalSettingsChange is set to true by default

Status & tagging log