r110556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110555‎ | r110556 | r110557 >
Date:10:13, 2 February 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
implemented summary field methods and added some docs
Modified paths:
  • /trunk/extensions/EducationProgram/includes/EPCourse.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPDBObject.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPOrg.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/includes/EPDBObject.php
@@ -15,11 +15,29 @@
1616 * * insertIntoDB
1717 * * updateInDB
1818 * * loadSummaryFields
 19+ * * getSummaryFields
1920 *
2021 * Deriving classes must register their table and field prefix in $egEPDBObjects.
2122 * Syntax: $egEPDBObjects['DrivingClassName'] = array( 'table' => 'table_name', 'prefix' => 'fieldprefix_' );
2223 * Example: $egEPDBObjects['EPOrg'] = array( 'table' => 'ep_orgs', 'prefix' => 'org_' );
2324 *
 25+ * Main instance methods:
 26+ * * getField(s)
 27+ * * setField(s)
 28+ * * writeToDB
 29+ * * removeFromDB
 30+ * * updateInDB
 31+ *
 32+ * Main static methods:
 33+ * * select
 34+ * * update
 35+ * * delete
 36+ * * count
 37+ * * has
 38+ * * selectRow
 39+ * * selectFields
 40+ * * selectFieldsRow
 41+ *
2442 * @since 0.1
2543 *
2644 * @file EPDBObject.php
Index: trunk/extensions/EducationProgram/includes/EPOrg.php
@@ -63,6 +63,21 @@
6464 'online_ambs' => 0,
6565 );
6666 }
 67+
 68+ /**
 69+ * (non-PHPdoc)
 70+ * @see EPDBObject::getSummaryFields()
 71+ */
 72+ public static function getSummaryFields() {
 73+ return array(
 74+ 'active',
 75+ 'courses',
 76+ 'students',
 77+ 'instructors',
 78+ 'campus_ambs',
 79+ 'online_ambs',
 80+ );
 81+ }
6782
6883 /**
6984 * (non-PHPdoc)
Index: trunk/extensions/EducationProgram/includes/EPCourse.php
@@ -141,6 +141,16 @@
142142 'students' => 0,
143143 );
144144 }
 145+
 146+ /**
 147+ * (non-PHPdoc)
 148+ * @see EPDBObject::getSummaryFields()
 149+ */
 150+ public static function getSummaryFields() {
 151+ return array(
 152+ 'students',
 153+ );
 154+ }
145155
146156 /**
147157 * Returns the students enrolled in this course.

Status & tagging log