r110479 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110478‎ | r110479 | r110480 >
Date:14:50, 1 February 2012
Author:maxsem
Status:ok
Tags:miscextensions 
Comment:
Revert r110232 per objections from i18n people
Modified paths:
  • /trunk/extensions/FeaturedFeeds/FeaturedFeeds.body.php (modified) (history)
  • /trunk/extensions/FeaturedFeeds/FeaturedFeeds.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FeaturedFeeds/FeaturedFeeds.body.php
@@ -295,6 +295,14 @@
296296 $this->description = $this->msg( $this->options['description'] )->text();
297297 $pageMsg = $this->msg( $this->options['page'] )->params( $this->language->getCode() );
298298 if ( $pageMsg->isDisabled() ) {
 299+ // fall back manually, messages can be existent but empty
 300+ if ( $this->language->getCode() != $wgLanguageCode ) {
 301+ $pageMsg = wfMessage( $this->options['page'] )
 302+ ->params( $this->language->getCode() )
 303+ ->inContentLanguage();
 304+ }
 305+ }
 306+ if ( $pageMsg->isDisabled() ) {
299307 return;
300308 }
301309 $this->page = $pageMsg->plain();
Index: trunk/extensions/FeaturedFeeds/FeaturedFeeds.i18n.php
@@ -20,42 +20,49 @@
2121 'ffeed-invalid-timestamp' => 'Invalid feed timestamp',
2222
2323 # Featured Article
 24+ 'ffeed-featured-page' => '', # do not localise
2425 'ffeed-featured-title' => '{{SITENAME}} featured articles feed',
2526 'ffeed-featured-short-title' => 'Featured articles',
2627 'ffeed-featured-desc' => 'Best articles {{SITENAME}} has to offer',
2728 'ffeed-featured-entry' => '{{LOCALMONTHNAME}} {{LOCALDAY}} {{SITENAME}} featured article',
2829
2930 # Good Article
 31+ 'ffeed-good-page' => '', # do not localise
3032 'ffeed-good-title' => '{{SITENAME}} good articles feed',
3133 'ffeed-good-short-title' => 'Good articles',
3234 'ffeed-good-desc' => 'Good articles {{SITENAME}} has to offer',
3335 'ffeed-good-entry' => '{{LOCALMONTHNAME}} {{LOCALDAY}} {{SITENAME}} good article',
3436
3537 # On this day...
 38+ 'ffeed-onthisday-page' => '', # do not localise
3639 'ffeed-onthisday-title' => '{{SITENAME}} "On this day..." feed',
3740 'ffeed-onthisday-short-title' => 'On this day...',
3841 'ffeed-onthisday-desc' => 'Historical events on this day',
3942 'ffeed-onthisday-entry' => 'On this day: {{LOCALMONTHNAME}} {{LOCALDAY}}',
4043
4144 # Did You Know?
 45+ 'ffeed-dyk-page' => '', # do not localise
4246 'ffeed-dyk-title' => '{{SITENAME}} "Did You Know?" feed',
4347 'ffeed-dyk-short-title' => 'Did you know?',
4448 'ffeed-dyk-desc' => "From {{SITENAME}}'s newest content",
4549 'ffeed-dyk-entry' => 'Did you know?: {{LOCALMONTHNAME}} {{LOCALDAY}}',
4650
4751 // Media Of The Day
 52+ 'ffeed-motd-page' => '', # do not localise
4853 'ffeed-motd-title' => '{{SITENAME}} media of the day feed',
4954 'ffeed-motd-short-title' => 'Media of the day',
5055 'ffeed-motd-desc' => 'Some of the finest media on {{SITENAME}}',
5156 'ffeed-motd-entry' => '{{SITENAME}} media of the day for {{LOCALMONTHNAME}} {{LOCALDAY}}',
5257
5358 # Picture Of The Day
 59+ 'ffeed-potd-page' => '', # do not localise
5460 'ffeed-potd-title' => '{{SITENAME}} picture of the day feed',
5561 'ffeed-potd-short-title' => 'Picture of the day',
5662 'ffeed-potd-desc' => 'Some of the finest images on {{SITENAME}}',
5763 'ffeed-potd-entry' => '{{SITENAME}} picture of the day for {{LOCALMONTHNAME}} {{LOCALDAY}}',
5864
5965 # Quote of the Day
 66+ 'ffeed-qotd-page' => '', # do not localise
6067 'ffeed-qotd-title' => '{{SITENAME}} quote of the day feed',
6168 'ffeed-qotd-short-title' => 'Quote of the day',
6269 'ffeed-qotd-desc' => 'Some of the finest quotes on {{SITENAME}}',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110232Revert r110161 and remove the empty configuration messages instead - let auto...maxsem11:42, 29 January 2012

Status & tagging log